feat(tower): Record http.response.status_code on HTTP transactions#1253
Open
lcian wants to merge 5 commits into
Open
feat(tower): Record http.response.status_code on HTTP transactions#1253lcian wants to merge 5 commits into
lcian wants to merge 5 commits into
Conversation
SentryHttpLayer already mapped response statuses to SpanStatus, but did not attach the numeric HTTP status as span/transaction data. Record the canonical http.response.status_code attribute from sentry-conventions. Co-Authored-By: Claude <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 951babc. Configure here.
Only set the attribute when it is not already present, matching the existing guard around transaction status. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Danger requires the PR number in Unreleased changelog entries. Co-Authored-By: Claude <noreply@anthropic.com>
lcian
marked this pull request as ready for review
July 21, 2026 11:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
SentryHttpLayerstarts a transaction for an incoming request, successful responses now also set the canonicalhttp.response.status_codeattribute on transaction data. The existingSpanStatusmapping is unchanged; this adds the numeric status so Sentry can surface HTTP response codes the same way other SDKs do.Only the tower HTTP integration is affected, and only when transactions are enabled.
Context: I was trying to debug something and find traces with a particular status code.